How to address a suspicion that my co-worker is not reviewing my work?I heavily skewed the data by repeatedly submitting the same anonymous workplace survey and the CEO is reacting, how do I come clean?How to talk about a coworker work in a reportHow to thank co-worker for good report/praise to my managersHow to ask co-worker to stop vaping?How to deal with a co-worker who assumes “unofficial” ownership of a project?How to deal with co-workers that hate each otherHow do I work with someone that shows no effort of working with me?
Did a flight controller ever answer Flight with a no-go?
Why don't electrons take the shorter path in coils?
Checking a beta regression model via glmmTMB with DHARMa package
Efficiently pathfinding many flocking enemies around obstacles
How to use "Du hast/ Du hattest'?
Cross-referencing enumerate item
Which DB for 1 table with 100 Million rows per year?
What is the hex versus octal timeline?
Algorithms vs LP or MIP
Is there any way to keep a player from killing an NPC?
Irish Snap: Variant Rules
Does norwegian.no airline overbook flights?
What is the history of the university asylum law?
What is the difference between true neutral and unaligned?
What are some interesting features that are common cross-linguistically but don't exist in English?
Are modern clipless shoes and pedals that much better than toe clips and straps?
Why does The Ancient One think differently about Doctor Strange in Endgame than the film Doctor Strange?
Numbers Decrease while Letters Increase
What magic extends life or grants immortality?
Was Switzerland really impossible to invade during WW2?
What is the best option for High availability on a data warehouse?
Accent on í misaligned in bibliography / citation
Dealing with an extrovert co-worker
If the first law of thermodynamics ensures conservation of energy, why does it allow systems to lose energy?
How to address a suspicion that my co-worker is not reviewing my work?
I heavily skewed the data by repeatedly submitting the same anonymous workplace survey and the CEO is reacting, how do I come clean?How to talk about a coworker work in a reportHow to thank co-worker for good report/praise to my managersHow to ask co-worker to stop vaping?How to deal with a co-worker who assumes “unofficial” ownership of a project?How to deal with co-workers that hate each otherHow do I work with someone that shows no effort of working with me?
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;
On each project we submit drafts for peer review. Whenever one particular colleague of mine performs a review of my work, she always returns it with no comments. I always get comments from everyone else. This leads me to suspect that she is not reviewing it and simply billing time to the project.
I work on engineering problems that provide drinking water to communities - I rely on an effective review process to catch occasional errors and identify potential improvements in my work.
How should I address this suspicion, either directly with my co-worker or with my manager (or someone else)?
In the past I've:
- Mentioned to my manager that I consistently get no comments from this one individual
- Mentioned to my co-worker that other reviewers consistently have feedback for me and would appreciate feedback from her
coworking collaboration quality
edited 8 mins ago
Jay
8,4232 gold badges23 silver badges53 bronze badges
asked 9 hours ago
RR 2RR 2
1,0451 gold badge4 silver badges21 bronze badges
|
show 7 more comments
On each project we submit drafts for peer review. Whenever one particular colleague of mine performs a review of my work, she always returns it with no comments. I always get comments from everyone else. This leads me to suspect that she is not reviewing it and simply billing time to the project.
I work on engineering problems that provide drinking water to communities - I rely on an effective review process to catch occasional errors and identify potential improvements in my work.
How should I address this suspicion, either directly with my co-worker or with my manager (or someone else)?
In the past I've:
- Mentioned to my manager that I consistently get no comments from this one individual
- Mentioned to my co-worker that other reviewers consistently have feedback for me and would appreciate feedback from her
coworking collaboration quality
edited 8 mins ago
Jay
8,4232 gold badges23 silver badges53 bronze badges
asked 9 hours ago
RR 2RR 2
1,0451 gold badge4 silver badges21 bronze badges
1
Have you given the same work to someone else to review? Do they come up with issues?
– Erik
9 hours ago
3
Does your employer have a standard for what a review is supposed to entail, or what a review is supposed to find? If not, it would be no surprise at all that there is some variation due to personal style or personal interpretation of what a "review" is supposed to be. She may be innocently surprised by your implication that she should be finding something.
– dwizum
9 hours ago
1
What @dwizum said. For some people a review is looking over the changeset, for others raising comments for every infraction of coding style, e.g. blank lines, and for others comparing parts of the commit to the requirements. Sounds like you need to have a meeting to agree on what constitutes a PR. It's all about communication.
– Justin
9 hours ago
For these particular projects we are the only two persons that can perform the work. So we always review each other's work. I give her many comments because I want to make sure she puts out quality work. I get no comments.
– RR 2
9 hours ago
That's beside the point. Who gets to decide what "quality work" means? How to you measure that? How do you determine if someone else is making quality work? Those questions seem trivial and obvious, but get a dozen developers in a room, who have no pre-agreed upon standard, and ask them simply "review this code" and you'll almost certainly get 12 different answers. You have to know what a review is supposed to mean before you can decide if a given review is "good" or thorough or whatever.
– dwizum
8 hours ago
|
show 7 more comments
On each project we submit drafts for peer review. Whenever one particular colleague of mine performs a review of my work, she always returns it with no comments. I always get comments from everyone else. This leads me to suspect that she is not reviewing it and simply billing time to the project.
I work on engineering problems that provide drinking water to communities - I rely on an effective review process to catch occasional errors and identify potential improvements in my work.
How should I address this suspicion, either directly with my co-worker or with my manager (or someone else)?
In the past I've:
- Mentioned to my manager that I consistently get no comments from this one individual
- Mentioned to my co-worker that other reviewers consistently have feedback for me and would appreciate feedback from her
coworking collaboration quality
edited 8 mins ago
Jay
8,4232 gold badges23 silver badges53 bronze badges
asked 9 hours ago
RR 2RR 2
1,0451 gold badge4 silver badges21 bronze badges
On each project we submit drafts for peer review. Whenever one particular colleague of mine performs a review of my work, she always returns it with no comments. I always get comments from everyone else. This leads me to suspect that she is not reviewing it and simply billing time to the project.
I work on engineering problems that provide drinking water to communities - I rely on an effective review process to catch occasional errors and identify potential improvements in my work.
How should I address this suspicion, either directly with my co-worker or with my manager (or someone else)?
In the past I've:
- Mentioned to my manager that I consistently get no comments from this one individual
- Mentioned to my co-worker that other reviewers consistently have feedback for me and would appreciate feedback from her
coworking collaboration quality
coworking collaboration quality
edited 8 mins ago
Jay
8,4232 gold badges23 silver badges53 bronze badges
asked 9 hours ago
RR 2RR 2
1,0451 gold badge4 silver badges21 bronze badges
edited 8 mins ago
Jay
8,4232 gold badges23 silver badges53 bronze badges
asked 9 hours ago
RR 2RR 2
1,0451 gold badge4 silver badges21 bronze badges
edited 8 mins ago
Jay
8,4232 gold badges23 silver badges53 bronze badges
edited 8 mins ago
Jay
8,4232 gold badges23 silver badges53 bronze badges
edited 8 mins ago
Jay
8,4232 gold badges23 silver badges53 bronze badges
8,4232 gold badges23 silver badges53 bronze badges
asked 9 hours ago
RR 2RR 2
1,0451 gold badge4 silver badges21 bronze badges
asked 9 hours ago
RR 2RR 2
1,0451 gold badge4 silver badges21 bronze badges
asked 9 hours ago
RR 2RR 2
1,0451 gold badge4 silver badges21 bronze badges
1,0451 gold badge4 silver badges21 bronze badges
1
Have you given the same work to someone else to review? Do they come up with issues?
– Erik
9 hours ago
3
Does your employer have a standard for what a review is supposed to entail, or what a review is supposed to find? If not, it would be no surprise at all that there is some variation due to personal style or personal interpretation of what a "review" is supposed to be. She may be innocently surprised by your implication that she should be finding something.
– dwizum
9 hours ago
1
What @dwizum said. For some people a review is looking over the changeset, for others raising comments for every infraction of coding style, e.g. blank lines, and for others comparing parts of the commit to the requirements. Sounds like you need to have a meeting to agree on what constitutes a PR. It's all about communication.
– Justin
9 hours ago
For these particular projects we are the only two persons that can perform the work. So we always review each other's work. I give her many comments because I want to make sure she puts out quality work. I get no comments.
– RR 2
9 hours ago
That's beside the point. Who gets to decide what "quality work" means? How to you measure that? How do you determine if someone else is making quality work? Those questions seem trivial and obvious, but get a dozen developers in a room, who have no pre-agreed upon standard, and ask them simply "review this code" and you'll almost certainly get 12 different answers. You have to know what a review is supposed to mean before you can decide if a given review is "good" or thorough or whatever.
– dwizum
8 hours ago
|
show 7 more comments
1
Have you given the same work to someone else to review? Do they come up with issues?
– Erik
9 hours ago
3
Does your employer have a standard for what a review is supposed to entail, or what a review is supposed to find? If not, it would be no surprise at all that there is some variation due to personal style or personal interpretation of what a "review" is supposed to be. She may be innocently surprised by your implication that she should be finding something.
– dwizum
9 hours ago
1
What @dwizum said. For some people a review is looking over the changeset, for others raising comments for every infraction of coding style, e.g. blank lines, and for others comparing parts of the commit to the requirements. Sounds like you need to have a meeting to agree on what constitutes a PR. It's all about communication.
– Justin
9 hours ago
For these particular projects we are the only two persons that can perform the work. So we always review each other's work. I give her many comments because I want to make sure she puts out quality work. I get no comments.
– RR 2
9 hours ago
That's beside the point. Who gets to decide what "quality work" means? How to you measure that? How do you determine if someone else is making quality work? Those questions seem trivial and obvious, but get a dozen developers in a room, who have no pre-agreed upon standard, and ask them simply "review this code" and you'll almost certainly get 12 different answers. You have to know what a review is supposed to mean before you can decide if a given review is "good" or thorough or whatever.
– dwizum
8 hours ago
1
1
Have you given the same work to someone else to review? Do they come up with issues?
– Erik
9 hours ago
Have you given the same work to someone else to review? Do they come up with issues?
– Erik
9 hours ago
3
3
Does your employer have a standard for what a review is supposed to entail, or what a review is supposed to find? If not, it would be no surprise at all that there is some variation due to personal style or personal interpretation of what a "review" is supposed to be. She may be innocently surprised by your implication that she should be finding something.
– dwizum
9 hours ago
Does your employer have a standard for what a review is supposed to entail, or what a review is supposed to find? If not, it would be no surprise at all that there is some variation due to personal style or personal interpretation of what a "review" is supposed to be. She may be innocently surprised by your implication that she should be finding something.
– dwizum
9 hours ago
1
1
What @dwizum said. For some people a review is looking over the changeset, for others raising comments for every infraction of coding style, e.g. blank lines, and for others comparing parts of the commit to the requirements. Sounds like you need to have a meeting to agree on what constitutes a PR. It's all about communication.
– Justin
9 hours ago
What @dwizum said. For some people a review is looking over the changeset, for others raising comments for every infraction of coding style, e.g. blank lines, and for others comparing parts of the commit to the requirements. Sounds like you need to have a meeting to agree on what constitutes a PR. It's all about communication.
– Justin
9 hours ago
For these particular projects we are the only two persons that can perform the work. So we always review each other's work. I give her many comments because I want to make sure she puts out quality work. I get no comments.
– RR 2
9 hours ago
For these particular projects we are the only two persons that can perform the work. So we always review each other's work. I give her many comments because I want to make sure she puts out quality work. I get no comments.
– RR 2
9 hours ago
That's beside the point. Who gets to decide what "quality work" means? How to you measure that? How do you determine if someone else is making quality work? Those questions seem trivial and obvious, but get a dozen developers in a room, who have no pre-agreed upon standard, and ask them simply "review this code" and you'll almost certainly get 12 different answers. You have to know what a review is supposed to mean before you can decide if a given review is "good" or thorough or whatever.
– dwizum
8 hours ago
That's beside the point. Who gets to decide what "quality work" means? How to you measure that? How do you determine if someone else is making quality work? Those questions seem trivial and obvious, but get a dozen developers in a room, who have no pre-agreed upon standard, and ask them simply "review this code" and you'll almost certainly get 12 different answers. You have to know what a review is supposed to mean before you can decide if a given review is "good" or thorough or whatever.
– dwizum
8 hours ago
|
show 7 more comments
4 Answers
4
active
oldest
votes
If you are sure there are issues that should have been caught (sometimes there really are no comments to be made) then it sounds like you have already gone through all of the usual steps by asking her about this and escalating to her manager. I think your managers are the same from the way you have discussed this, but if not then you can escalate to your own manager or whomever is accountable for the work you are doing.
A simple way is to add an obvious error (or multiple errors) into your work and submit it for review. But it doesn't seem a good idea just to try and catch someone out in that way and this may backfire if the manager thinks you are deliberately trying to catch her out
Perhaps by saying to your manager that you found an error yourself after you received the review back with no comments and that the obvious error was not caught, that might work
answered 9 hours ago
FiredragonFiredragon
9001 gold badge1 silver badge6 bronze badges
1
The other possibility is she's reviewing things "late" and is already seeing comments, assuming it's the kind of review where everyone sees everyone else's comments. As a side note, I was close to down-voting your answer because it also includes the "lay trap for co-worker" suggestion.
– Julie in Austin
8 hours ago
add a comment |
Talk to each other - have a team / departmental meeting to agree on what constitutes a Pull Request (Peer Review, etc).
Maybe you also have different levels of PR, depending on the complexity of the commit.
- Just review the changes?
- Compare changes against requirements spec?
- Has submitter also done minor refactoring to improve the codebase?
- Are there unit tests?
It doesn't matter as long as you have generally accepted guidelines and ideally more than one approval.
answered 9 hours ago
JustinJustin
5,4302 gold badges10 silver badges26 bronze badges
1
The job expectations are simple. That she perform a review, checking everything. I'm not talking to her about it anymore. She should be replaced.
– RR 2
9 hours ago
2
@RR2I'm not talking to her about it anymore.Then I guess you'll never know the answer to your question?
– KingDuken
9 hours ago
1
@RR2 I'm not talking to her about it anymore. She should be replaced - then what exactly is your motivation for asking this question? It seems like you're not interested in improving the process. Are you trying to get help in somehow "trapping" her, or proving to some third party that she's not doing her job?
– dwizum
8 hours ago
2
@RR2 you have been given a direct, and very much correct answer: communicate, verbally. Please act professionally and assume good will until proven otherwise. Respect your colleagues.
– aaaaaa
8 hours ago
1
If someone is not reviewing the work, and just taking the pay, that is not professional. Why shouldn't this be challenged to get a good review. This is an important part of the project process. That is my main question how do I prove otherwise? After a design fails and a forensic analysis traces it back to a mistake that should have been caught in the peer review process?
– RR 2
8 hours ago
|
show 1 more comment
Since you're talking about math models for water supply equipment...
There should be a business process for approving important and life-critical technical decisions in your company. In its simplest form, there should be at least a checklist document where each of the experts involved in review should write "checked and approved" and put their signature next to every action they should have performed during the review. That checklist would automatically define the scope of the review.
A better way could be to have another expert double-check the calculations independently, including the choice of parameters and put their signature only if everything matches. But that's another level.
Talk to your boss. It's a business process that they should have established.
answered 8 hours ago
Igor GIgor G
4931 silver badge6 bronze badges
This is excellent. I wish there was a checklist already. Just a checkbox to say review performed at this point.
– RR 2
7 hours ago
add a comment |
Lol, how about leaving a trace of comments in your flow to fill out ?
it could be simple as - if you get here write 5x6 result in the next comment line
2-3 times comments are going to be missing - you have empiric proof and can go to your manager with it
if comments are there - she does the review
Unless you don`t like the person and looking for a reason to complain about her to your manager :)
Edit:
@aaaaaa if , as OP stated, no comments came from this person and no change from verbal communication (request for comments), there should be an indicator to confirm / support his claim that code is not reviewed
@cdkMoose from what i understand OP is responsible for his own code and PR is NOT a formality, there is always a chance of missing something. By not performing a PR that "coworker" is putting OP and his work / status / advancement at risk
@dwizum from the post its apparent that conflict is already happening. No reaction to OP discussions with this coworker, and next stage is to talk to a manager, hollow stipulations are worse than indicators because its always going to be OP word against coworker
@JulieinAustin what is wrong with calling her out if no feedback is given and no reaction to one on ones?
@dwizum i see, the word choice may have been not a best one. i meant it as dictionary does: "a thing that is done simply to comply with requirements of etiquette, regulations, or custom." , Meaning that it is part of methodology in the OPs company
answered 8 hours ago
StraderStrader
5,2791 gold badge8 silver badges32 bronze badges
Comments are not for extended discussion; this conversation has been moved to chat.
– Mister Positive♦
5 hours ago
add a comment |
Your Answer
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "423"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
noCode: true, onDemand: false,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f142673%2fhow-to-address-a-suspicion-that-my-co-worker-is-not-reviewing-my-work%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
StackExchange.ready(function ()
$("#show-editor-button input, #show-editor-button button").click(function ()
var showEditor = function()
$("#show-editor-button").addClass("d-none");
$("#post-form").removeClass("d-none");
StackExchange.editor.finallyInit();
;
var useFancy = $(this).data('confirm-use-fancy');
if(useFancy == 'True')
var popupTitle = $(this).data('confirm-fancy-title');
var popupBody = $(this).data('confirm-fancy-body');
var popupAccept = $(this).data('confirm-fancy-accept-button');
$(this).loadPopup(
url: '/post/self-answer-popup',
loaded: function(popup)
var pTitle = $(popup).find('h2');
var pBody = $(popup).find('.popup-body');
var pSubmit = $(popup).find('.popup-submit');
pTitle.text(popupTitle);
pBody.html(popupBody);
pSubmit.val(popupAccept).click(showEditor);
)
else
var confirmText = $(this).data('confirm-text');
if (confirmText ? confirm(confirmText) : true)
showEditor();
);
);
4 Answers
4
active
oldest
votes
4 Answers
4
active
oldest
votes
active
oldest
votes
active
oldest
votes
If you are sure there are issues that should have been caught (sometimes there really are no comments to be made) then it sounds like you have already gone through all of the usual steps by asking her about this and escalating to her manager. I think your managers are the same from the way you have discussed this, but if not then you can escalate to your own manager or whomever is accountable for the work you are doing.
A simple way is to add an obvious error (or multiple errors) into your work and submit it for review. But it doesn't seem a good idea just to try and catch someone out in that way and this may backfire if the manager thinks you are deliberately trying to catch her out
Perhaps by saying to your manager that you found an error yourself after you received the review back with no comments and that the obvious error was not caught, that might work
answered 9 hours ago
FiredragonFiredragon
9001 gold badge1 silver badge6 bronze badges
1
The other possibility is she's reviewing things "late" and is already seeing comments, assuming it's the kind of review where everyone sees everyone else's comments. As a side note, I was close to down-voting your answer because it also includes the "lay trap for co-worker" suggestion.
– Julie in Austin
8 hours ago
add a comment |
If you are sure there are issues that should have been caught (sometimes there really are no comments to be made) then it sounds like you have already gone through all of the usual steps by asking her about this and escalating to her manager. I think your managers are the same from the way you have discussed this, but if not then you can escalate to your own manager or whomever is accountable for the work you are doing.
A simple way is to add an obvious error (or multiple errors) into your work and submit it for review. But it doesn't seem a good idea just to try and catch someone out in that way and this may backfire if the manager thinks you are deliberately trying to catch her out
Perhaps by saying to your manager that you found an error yourself after you received the review back with no comments and that the obvious error was not caught, that might work
answered 9 hours ago
FiredragonFiredragon
9001 gold badge1 silver badge6 bronze badges
1
The other possibility is she's reviewing things "late" and is already seeing comments, assuming it's the kind of review where everyone sees everyone else's comments. As a side note, I was close to down-voting your answer because it also includes the "lay trap for co-worker" suggestion.
– Julie in Austin
8 hours ago
add a comment |
If you are sure there are issues that should have been caught (sometimes there really are no comments to be made) then it sounds like you have already gone through all of the usual steps by asking her about this and escalating to her manager. I think your managers are the same from the way you have discussed this, but if not then you can escalate to your own manager or whomever is accountable for the work you are doing.
A simple way is to add an obvious error (or multiple errors) into your work and submit it for review. But it doesn't seem a good idea just to try and catch someone out in that way and this may backfire if the manager thinks you are deliberately trying to catch her out
Perhaps by saying to your manager that you found an error yourself after you received the review back with no comments and that the obvious error was not caught, that might work
answered 9 hours ago
FiredragonFiredragon
9001 gold badge1 silver badge6 bronze badges
If you are sure there are issues that should have been caught (sometimes there really are no comments to be made) then it sounds like you have already gone through all of the usual steps by asking her about this and escalating to her manager. I think your managers are the same from the way you have discussed this, but if not then you can escalate to your own manager or whomever is accountable for the work you are doing.
A simple way is to add an obvious error (or multiple errors) into your work and submit it for review. But it doesn't seem a good idea just to try and catch someone out in that way and this may backfire if the manager thinks you are deliberately trying to catch her out
Perhaps by saying to your manager that you found an error yourself after you received the review back with no comments and that the obvious error was not caught, that might work
answered 9 hours ago
FiredragonFiredragon
9001 gold badge1 silver badge6 bronze badges
answered 9 hours ago
FiredragonFiredragon
9001 gold badge1 silver badge6 bronze badges
answered 9 hours ago
FiredragonFiredragon
9001 gold badge1 silver badge6 bronze badges
answered 9 hours ago
FiredragonFiredragon
9001 gold badge1 silver badge6 bronze badges
9001 gold badge1 silver badge6 bronze badges
1
The other possibility is she's reviewing things "late" and is already seeing comments, assuming it's the kind of review where everyone sees everyone else's comments. As a side note, I was close to down-voting your answer because it also includes the "lay trap for co-worker" suggestion.
– Julie in Austin
8 hours ago
add a comment |
1
The other possibility is she's reviewing things "late" and is already seeing comments, assuming it's the kind of review where everyone sees everyone else's comments. As a side note, I was close to down-voting your answer because it also includes the "lay trap for co-worker" suggestion.
– Julie in Austin
8 hours ago
1
1
The other possibility is she's reviewing things "late" and is already seeing comments, assuming it's the kind of review where everyone sees everyone else's comments. As a side note, I was close to down-voting your answer because it also includes the "lay trap for co-worker" suggestion.
– Julie in Austin
8 hours ago
The other possibility is she's reviewing things "late" and is already seeing comments, assuming it's the kind of review where everyone sees everyone else's comments. As a side note, I was close to down-voting your answer because it also includes the "lay trap for co-worker" suggestion.
– Julie in Austin
8 hours ago
add a comment |
Talk to each other - have a team / departmental meeting to agree on what constitutes a Pull Request (Peer Review, etc).
Maybe you also have different levels of PR, depending on the complexity of the commit.
- Just review the changes?
- Compare changes against requirements spec?
- Has submitter also done minor refactoring to improve the codebase?
- Are there unit tests?
It doesn't matter as long as you have generally accepted guidelines and ideally more than one approval.
answered 9 hours ago
JustinJustin
5,4302 gold badges10 silver badges26 bronze badges
1
The job expectations are simple. That she perform a review, checking everything. I'm not talking to her about it anymore. She should be replaced.
– RR 2
9 hours ago
2
@RR2I'm not talking to her about it anymore.Then I guess you'll never know the answer to your question?
– KingDuken
9 hours ago
1
@RR2 I'm not talking to her about it anymore. She should be replaced - then what exactly is your motivation for asking this question? It seems like you're not interested in improving the process. Are you trying to get help in somehow "trapping" her, or proving to some third party that she's not doing her job?
– dwizum
8 hours ago
2
@RR2 you have been given a direct, and very much correct answer: communicate, verbally. Please act professionally and assume good will until proven otherwise. Respect your colleagues.
– aaaaaa
8 hours ago
1
If someone is not reviewing the work, and just taking the pay, that is not professional. Why shouldn't this be challenged to get a good review. This is an important part of the project process. That is my main question how do I prove otherwise? After a design fails and a forensic analysis traces it back to a mistake that should have been caught in the peer review process?
– RR 2
8 hours ago
|
show 1 more comment
Talk to each other - have a team / departmental meeting to agree on what constitutes a Pull Request (Peer Review, etc).
Maybe you also have different levels of PR, depending on the complexity of the commit.
- Just review the changes?
- Compare changes against requirements spec?
- Has submitter also done minor refactoring to improve the codebase?
- Are there unit tests?
It doesn't matter as long as you have generally accepted guidelines and ideally more than one approval.
answered 9 hours ago
JustinJustin
5,4302 gold badges10 silver badges26 bronze badges
1
The job expectations are simple. That she perform a review, checking everything. I'm not talking to her about it anymore. She should be replaced.
– RR 2
9 hours ago
2
@RR2I'm not talking to her about it anymore.Then I guess you'll never know the answer to your question?
– KingDuken
9 hours ago
1
@RR2 I'm not talking to her about it anymore. She should be replaced - then what exactly is your motivation for asking this question? It seems like you're not interested in improving the process. Are you trying to get help in somehow "trapping" her, or proving to some third party that she's not doing her job?
– dwizum
8 hours ago
2
@RR2 you have been given a direct, and very much correct answer: communicate, verbally. Please act professionally and assume good will until proven otherwise. Respect your colleagues.
– aaaaaa
8 hours ago
1
If someone is not reviewing the work, and just taking the pay, that is not professional. Why shouldn't this be challenged to get a good review. This is an important part of the project process. That is my main question how do I prove otherwise? After a design fails and a forensic analysis traces it back to a mistake that should have been caught in the peer review process?
– RR 2
8 hours ago
|
show 1 more comment
Talk to each other - have a team / departmental meeting to agree on what constitutes a Pull Request (Peer Review, etc).
Maybe you also have different levels of PR, depending on the complexity of the commit.
- Just review the changes?
- Compare changes against requirements spec?
- Has submitter also done minor refactoring to improve the codebase?
- Are there unit tests?
It doesn't matter as long as you have generally accepted guidelines and ideally more than one approval.
answered 9 hours ago
JustinJustin
5,4302 gold badges10 silver badges26 bronze badges
Talk to each other - have a team / departmental meeting to agree on what constitutes a Pull Request (Peer Review, etc).
Maybe you also have different levels of PR, depending on the complexity of the commit.
- Just review the changes?
- Compare changes against requirements spec?
- Has submitter also done minor refactoring to improve the codebase?
- Are there unit tests?
It doesn't matter as long as you have generally accepted guidelines and ideally more than one approval.
answered 9 hours ago
JustinJustin
5,4302 gold badges10 silver badges26 bronze badges
answered 9 hours ago
JustinJustin
5,4302 gold badges10 silver badges26 bronze badges
answered 9 hours ago
JustinJustin
5,4302 gold badges10 silver badges26 bronze badges
answered 9 hours ago
JustinJustin
5,4302 gold badges10 silver badges26 bronze badges
5,4302 gold badges10 silver badges26 bronze badges
1
The job expectations are simple. That she perform a review, checking everything. I'm not talking to her about it anymore. She should be replaced.
– RR 2
9 hours ago
2
@RR2I'm not talking to her about it anymore.Then I guess you'll never know the answer to your question?
– KingDuken
9 hours ago
1
@RR2 I'm not talking to her about it anymore. She should be replaced - then what exactly is your motivation for asking this question? It seems like you're not interested in improving the process. Are you trying to get help in somehow "trapping" her, or proving to some third party that she's not doing her job?
– dwizum
8 hours ago
2
@RR2 you have been given a direct, and very much correct answer: communicate, verbally. Please act professionally and assume good will until proven otherwise. Respect your colleagues.
– aaaaaa
8 hours ago
1
If someone is not reviewing the work, and just taking the pay, that is not professional. Why shouldn't this be challenged to get a good review. This is an important part of the project process. That is my main question how do I prove otherwise? After a design fails and a forensic analysis traces it back to a mistake that should have been caught in the peer review process?
– RR 2
8 hours ago
|
show 1 more comment
1
The job expectations are simple. That she perform a review, checking everything. I'm not talking to her about it anymore. She should be replaced.
– RR 2
9 hours ago
2
@RR2I'm not talking to her about it anymore.Then I guess you'll never know the answer to your question?
– KingDuken
9 hours ago
1
@RR2 I'm not talking to her about it anymore. She should be replaced - then what exactly is your motivation for asking this question? It seems like you're not interested in improving the process. Are you trying to get help in somehow "trapping" her, or proving to some third party that she's not doing her job?
– dwizum
8 hours ago
2
@RR2 you have been given a direct, and very much correct answer: communicate, verbally. Please act professionally and assume good will until proven otherwise. Respect your colleagues.
– aaaaaa
8 hours ago
1
If someone is not reviewing the work, and just taking the pay, that is not professional. Why shouldn't this be challenged to get a good review. This is an important part of the project process. That is my main question how do I prove otherwise? After a design fails and a forensic analysis traces it back to a mistake that should have been caught in the peer review process?
– RR 2
8 hours ago
1
1
The job expectations are simple. That she perform a review, checking everything. I'm not talking to her about it anymore. She should be replaced.
– RR 2
9 hours ago
The job expectations are simple. That she perform a review, checking everything. I'm not talking to her about it anymore. She should be replaced.
– RR 2
9 hours ago
2
2
@RR2
I'm not talking to her about it anymore. Then I guess you'll never know the answer to your question?– KingDuken
9 hours ago
@RR2
I'm not talking to her about it anymore. Then I guess you'll never know the answer to your question?– KingDuken
9 hours ago
1
1
@RR2 I'm not talking to her about it anymore. She should be replaced - then what exactly is your motivation for asking this question? It seems like you're not interested in improving the process. Are you trying to get help in somehow "trapping" her, or proving to some third party that she's not doing her job?
– dwizum
8 hours ago
@RR2 I'm not talking to her about it anymore. She should be replaced - then what exactly is your motivation for asking this question? It seems like you're not interested in improving the process. Are you trying to get help in somehow "trapping" her, or proving to some third party that she's not doing her job?
– dwizum
8 hours ago
2
2
@RR2 you have been given a direct, and very much correct answer: communicate, verbally. Please act professionally and assume good will until proven otherwise. Respect your colleagues.
– aaaaaa
8 hours ago
@RR2 you have been given a direct, and very much correct answer: communicate, verbally. Please act professionally and assume good will until proven otherwise. Respect your colleagues.
– aaaaaa
8 hours ago
1
1
If someone is not reviewing the work, and just taking the pay, that is not professional. Why shouldn't this be challenged to get a good review. This is an important part of the project process. That is my main question how do I prove otherwise? After a design fails and a forensic analysis traces it back to a mistake that should have been caught in the peer review process?
– RR 2
8 hours ago
If someone is not reviewing the work, and just taking the pay, that is not professional. Why shouldn't this be challenged to get a good review. This is an important part of the project process. That is my main question how do I prove otherwise? After a design fails and a forensic analysis traces it back to a mistake that should have been caught in the peer review process?
– RR 2
8 hours ago
|
show 1 more comment
Since you're talking about math models for water supply equipment...
There should be a business process for approving important and life-critical technical decisions in your company. In its simplest form, there should be at least a checklist document where each of the experts involved in review should write "checked and approved" and put their signature next to every action they should have performed during the review. That checklist would automatically define the scope of the review.
A better way could be to have another expert double-check the calculations independently, including the choice of parameters and put their signature only if everything matches. But that's another level.
Talk to your boss. It's a business process that they should have established.
answered 8 hours ago
Igor GIgor G
4931 silver badge6 bronze badges
This is excellent. I wish there was a checklist already. Just a checkbox to say review performed at this point.
– RR 2
7 hours ago
add a comment |
Since you're talking about math models for water supply equipment...
There should be a business process for approving important and life-critical technical decisions in your company. In its simplest form, there should be at least a checklist document where each of the experts involved in review should write "checked and approved" and put their signature next to every action they should have performed during the review. That checklist would automatically define the scope of the review.
A better way could be to have another expert double-check the calculations independently, including the choice of parameters and put their signature only if everything matches. But that's another level.
Talk to your boss. It's a business process that they should have established.
answered 8 hours ago
Igor GIgor G
4931 silver badge6 bronze badges
This is excellent. I wish there was a checklist already. Just a checkbox to say review performed at this point.
– RR 2
7 hours ago
add a comment |
Since you're talking about math models for water supply equipment...
There should be a business process for approving important and life-critical technical decisions in your company. In its simplest form, there should be at least a checklist document where each of the experts involved in review should write "checked and approved" and put their signature next to every action they should have performed during the review. That checklist would automatically define the scope of the review.
A better way could be to have another expert double-check the calculations independently, including the choice of parameters and put their signature only if everything matches. But that's another level.
Talk to your boss. It's a business process that they should have established.
answered 8 hours ago
Igor GIgor G
4931 silver badge6 bronze badges
Since you're talking about math models for water supply equipment...
There should be a business process for approving important and life-critical technical decisions in your company. In its simplest form, there should be at least a checklist document where each of the experts involved in review should write "checked and approved" and put their signature next to every action they should have performed during the review. That checklist would automatically define the scope of the review.
A better way could be to have another expert double-check the calculations independently, including the choice of parameters and put their signature only if everything matches. But that's another level.
Talk to your boss. It's a business process that they should have established.
answered 8 hours ago
Igor GIgor G
4931 silver badge6 bronze badges
answered 8 hours ago
Igor GIgor G
4931 silver badge6 bronze badges
answered 8 hours ago
Igor GIgor G
4931 silver badge6 bronze badges
answered 8 hours ago
Igor GIgor G
4931 silver badge6 bronze badges
4931 silver badge6 bronze badges
This is excellent. I wish there was a checklist already. Just a checkbox to say review performed at this point.
– RR 2
7 hours ago
add a comment |
This is excellent. I wish there was a checklist already. Just a checkbox to say review performed at this point.
– RR 2
7 hours ago
This is excellent. I wish there was a checklist already. Just a checkbox to say review performed at this point.
– RR 2
7 hours ago
This is excellent. I wish there was a checklist already. Just a checkbox to say review performed at this point.
– RR 2
7 hours ago
add a comment |
Lol, how about leaving a trace of comments in your flow to fill out ?
it could be simple as - if you get here write 5x6 result in the next comment line
2-3 times comments are going to be missing - you have empiric proof and can go to your manager with it
if comments are there - she does the review
Unless you don`t like the person and looking for a reason to complain about her to your manager :)
Edit:
@aaaaaa if , as OP stated, no comments came from this person and no change from verbal communication (request for comments), there should be an indicator to confirm / support his claim that code is not reviewed
@cdkMoose from what i understand OP is responsible for his own code and PR is NOT a formality, there is always a chance of missing something. By not performing a PR that "coworker" is putting OP and his work / status / advancement at risk
@dwizum from the post its apparent that conflict is already happening. No reaction to OP discussions with this coworker, and next stage is to talk to a manager, hollow stipulations are worse than indicators because its always going to be OP word against coworker
@JulieinAustin what is wrong with calling her out if no feedback is given and no reaction to one on ones?
@dwizum i see, the word choice may have been not a best one. i meant it as dictionary does: "a thing that is done simply to comply with requirements of etiquette, regulations, or custom." , Meaning that it is part of methodology in the OPs company
answered 8 hours ago
StraderStrader
5,2791 gold badge8 silver badges32 bronze badges
Comments are not for extended discussion; this conversation has been moved to chat.
– Mister Positive♦
5 hours ago
add a comment |
Lol, how about leaving a trace of comments in your flow to fill out ?
it could be simple as - if you get here write 5x6 result in the next comment line
2-3 times comments are going to be missing - you have empiric proof and can go to your manager with it
if comments are there - she does the review
Unless you don`t like the person and looking for a reason to complain about her to your manager :)
Edit:
@aaaaaa if , as OP stated, no comments came from this person and no change from verbal communication (request for comments), there should be an indicator to confirm / support his claim that code is not reviewed
@cdkMoose from what i understand OP is responsible for his own code and PR is NOT a formality, there is always a chance of missing something. By not performing a PR that "coworker" is putting OP and his work / status / advancement at risk
@dwizum from the post its apparent that conflict is already happening. No reaction to OP discussions with this coworker, and next stage is to talk to a manager, hollow stipulations are worse than indicators because its always going to be OP word against coworker
@JulieinAustin what is wrong with calling her out if no feedback is given and no reaction to one on ones?
@dwizum i see, the word choice may have been not a best one. i meant it as dictionary does: "a thing that is done simply to comply with requirements of etiquette, regulations, or custom." , Meaning that it is part of methodology in the OPs company
answered 8 hours ago
StraderStrader
5,2791 gold badge8 silver badges32 bronze badges
Comments are not for extended discussion; this conversation has been moved to chat.
– Mister Positive♦
5 hours ago
add a comment |
Lol, how about leaving a trace of comments in your flow to fill out ?
it could be simple as - if you get here write 5x6 result in the next comment line
2-3 times comments are going to be missing - you have empiric proof and can go to your manager with it
if comments are there - she does the review
Unless you don`t like the person and looking for a reason to complain about her to your manager :)
Edit:
@aaaaaa if , as OP stated, no comments came from this person and no change from verbal communication (request for comments), there should be an indicator to confirm / support his claim that code is not reviewed
@cdkMoose from what i understand OP is responsible for his own code and PR is NOT a formality, there is always a chance of missing something. By not performing a PR that "coworker" is putting OP and his work / status / advancement at risk
@dwizum from the post its apparent that conflict is already happening. No reaction to OP discussions with this coworker, and next stage is to talk to a manager, hollow stipulations are worse than indicators because its always going to be OP word against coworker
@JulieinAustin what is wrong with calling her out if no feedback is given and no reaction to one on ones?
@dwizum i see, the word choice may have been not a best one. i meant it as dictionary does: "a thing that is done simply to comply with requirements of etiquette, regulations, or custom." , Meaning that it is part of methodology in the OPs company
answered 8 hours ago
StraderStrader
5,2791 gold badge8 silver badges32 bronze badges
Lol, how about leaving a trace of comments in your flow to fill out ?
it could be simple as - if you get here write 5x6 result in the next comment line
2-3 times comments are going to be missing - you have empiric proof and can go to your manager with it
if comments are there - she does the review
Unless you don`t like the person and looking for a reason to complain about her to your manager :)
Edit:
@aaaaaa if , as OP stated, no comments came from this person and no change from verbal communication (request for comments), there should be an indicator to confirm / support his claim that code is not reviewed
@cdkMoose from what i understand OP is responsible for his own code and PR is NOT a formality, there is always a chance of missing something. By not performing a PR that "coworker" is putting OP and his work / status / advancement at risk
@dwizum from the post its apparent that conflict is already happening. No reaction to OP discussions with this coworker, and next stage is to talk to a manager, hollow stipulations are worse than indicators because its always going to be OP word against coworker
@JulieinAustin what is wrong with calling her out if no feedback is given and no reaction to one on ones?
@dwizum i see, the word choice may have been not a best one. i meant it as dictionary does: "a thing that is done simply to comply with requirements of etiquette, regulations, or custom." , Meaning that it is part of methodology in the OPs company
answered 8 hours ago
StraderStrader
5,2791 gold badge8 silver badges32 bronze badges
edited 6 hours ago
answered 8 hours ago
StraderStrader
5,2791 gold badge8 silver badges32 bronze badges
answered 8 hours ago
StraderStrader
5,2791 gold badge8 silver badges32 bronze badges
answered 8 hours ago
StraderStrader
5,2791 gold badge8 silver badges32 bronze badges
5,2791 gold badge8 silver badges32 bronze badges
Comments are not for extended discussion; this conversation has been moved to chat.
– Mister Positive♦
5 hours ago
add a comment |
Comments are not for extended discussion; this conversation has been moved to chat.
– Mister Positive♦
5 hours ago
Comments are not for extended discussion; this conversation has been moved to chat.
– Mister Positive♦
5 hours ago
Comments are not for extended discussion; this conversation has been moved to chat.
– Mister Positive♦
5 hours ago
add a comment |
Thanks for contributing an answer to The Workplace Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f142673%2fhow-to-address-a-suspicion-that-my-co-worker-is-not-reviewing-my-work%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Have you given the same work to someone else to review? Do they come up with issues?
– Erik
9 hours ago
3
Does your employer have a standard for what a review is supposed to entail, or what a review is supposed to find? If not, it would be no surprise at all that there is some variation due to personal style or personal interpretation of what a "review" is supposed to be. She may be innocently surprised by your implication that she should be finding something.
– dwizum
9 hours ago
1
What @dwizum said. For some people a review is looking over the changeset, for others raising comments for every infraction of coding style, e.g. blank lines, and for others comparing parts of the commit to the requirements. Sounds like you need to have a meeting to agree on what constitutes a PR. It's all about communication.
– Justin
9 hours ago
For these particular projects we are the only two persons that can perform the work. So we always review each other's work. I give her many comments because I want to make sure she puts out quality work. I get no comments.
– RR 2
9 hours ago
That's beside the point. Who gets to decide what "quality work" means? How to you measure that? How do you determine if someone else is making quality work? Those questions seem trivial and obvious, but get a dozen developers in a room, who have no pre-agreed upon standard, and ask them simply "review this code" and you'll almost certainly get 12 different answers. You have to know what a review is supposed to mean before you can decide if a given review is "good" or thorough or whatever.
– dwizum
8 hours ago